Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [loading] Compatible with vue3.2.0~12 #12377

Merged
merged 2 commits into from
Apr 29, 2023
Merged

fix(components): [loading] Compatible with vue3.2.0~12 #12377

merged 2 commits into from
Apr 29, 2023

Conversation

chenxch
Copy link
Member

@chenxch chenxch commented Apr 9, 2023 •
edited

close #12351

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions
Copy link

github-actions bot commented Apr 9, 2023 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Apr 9, 2023
@github-actions
Copy link

github-actions bot commented Apr 9, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=12377
Please comment the example via this playground if needed.

@huangzhongzhong
Copy link
Contributor

huangzhongzhong commented Apr 9, 2023 •
edited by chenxch

3.2.0~3.2.12 The obtained vue instance data structure
image

^3.2.13
image

@chenxch chenxch merged commit 74daf8b into dev Apr 29, 2023
9 checks passed
@chenxch chenxch deleted the fix/loading_vue branch April 29, 2023 17:52
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request May 4, 2023
@chenxch @consultation-applio
fix(components): [loading] Compatible with vue3.2.0~12 (element-plus#…
7807e08 
…12377)

* fix(components): [loading] Compatible with vue3.2.0~12

* fix(components): [loading] add comment
This was referenced May 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

Assignees

@chenxch chenxch

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
3 participants
@chenxch @huangzhongzhong @btea