feat(components): [carousel] If the carousel height is auto apply item height #12388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @qq282126990, thank you for contributing element-plus.
|
|
|
|
Hello @qq282126990, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
🧪 Playground Preview: https://element-plus.run/?pr=12388 |
3 tasks
|
@qq282126990 It looks like you moved the changes from #11392 over here? |
|
Yes, because the previous branch is too old to be merged, there will be a lot of modified files |
The previous branch merge will have 200+ files prompting changes, so I pulled the latest code from dev again for modification |
|
Ok, let's review this pr. |
btea
reviewed
Apr 12, 2023
btea
reviewed
Apr 20, 2023
|
@btea Unnecessary code should be deleted, please check again |
btea
changed the title
btea
approved these changes
Apr 23, 2023
tolking
reviewed
Apr 29, 2023
…0/element-plus into carousels-height-auto
tolking
reviewed
May 14, 2023
tolking
approved these changes
May 14, 2023
|
Thanks for your contribution. |
This was referenced Sep 13, 2023
[Component] [carousel, carousel-item] Carousel 走马灯 不主动设置 height 属性高度 Carousel Item 无法自适应插槽的高度
#11368
Closed
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
…m height (element-plus#12388) * fix(components): [carousel] :height is auto and card direction vertical * fix(components): [carousel] :height is auto and card direction vertical * fix(components): [carousel] :height is auto and card direction 垂直 * feat(components): [carousel] height is adaptive when height is auto * feat(components): [carousel] height is adaptive when height is auto * fix(components): [carousel] :height is auto and card direction 垂直 * fix(components): [carousel] :height is auto and card direction 垂直 * fix(components): [carousel] :height is auto test.tsx * fix(components): [carousel] :height is auto and card direction * fix: delete zIndex * fix: delete ts type * fix: add test * fix: css modification * fix: delete doc inside * fix: Revise card width not adaptive * fix: Modify calcCardTranslate * fix: test * fix: calcCardTranslate * fix: remove redundant code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.