Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [tree] Fix TreeOptionProps #12511

Merged
merged 1 commit into from
May 13, 2023

Conversation

lyric-zemin
Copy link
Contributor

fix

export declare interface TreeOptionProps {
  disabled?: string | ((data: TreeNodeData, node: Node) => string)
}

to

export declare interface TreeOptionProps {
  disabled?: string | ((data: TreeNodeData, node: Node) => boolean)
}

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @lyric-zemin, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Apr 19, 2023
@github-actions
Copy link

Hello @lyric-zemin, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Apr 19, 2023

@lyric-zemin lyric-zemin changed the title fix(components): fix TreeOptionProps fix(components): [Tree] Fix TreeOptionProps Apr 19, 2023
@lyric-zemin lyric-zemin changed the title fix(components): [Tree] Fix TreeOptionProps fix(components): [tree] Fix TreeOptionProps Apr 19, 2023
@lyric-zemin
Copy link
Contributor Author

/label Components:[tree]

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Apr 19, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=12511
Please comment the example via this playground if needed.

@ryuhangyeong ryuhangyeong merged commit ea82d3f into element-plus:dev May 13, 2023
11 checks passed
This was referenced May 19, 2023
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
fix(components): fix TreeOptionProps

Co-authored-by: wu.zeMin <244@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants