Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [table-v2] Adjust the expandable #12519

Merged
merged 1 commit into from
May 1, 2023

Conversation

chenxch
Copy link
Member

@chenxch chenxch commented Apr 19, 2023

close #12518

before

after

The reason is that when the two values are not set, they are all undefined, which leads to a wrong judgment as an expandable mode.

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions
Copy link

github-actions bot commented Apr 19, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Apr 19, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=12519
Please comment the example via this playground if needed.

@ryuhangyeong ryuhangyeong self-requested a review April 30, 2023 10:01
@tolking tolking merged commit 66e74c8 into dev May 1, 2023
12 checks passed
@tolking tolking deleted the fix/table-v2_expandable branch May 1, 2023 08:18
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request May 4, 2023
This was referenced May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [table-v2] TableV2 自定义 cellRenderer 渲染出来的内容会有多余标签
3 participants