Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [image] fixed lazyLoad scroll end not loading #12596

Merged
merged 2 commits into from
May 1, 2023
Merged

fix(components): [image] fixed lazyLoad scroll end not loading #12596

merged 2 commits into from
May 1, 2023

Conversation

cicada-ah
Copy link
Contributor

@cicada-ah cicada-ah commented Apr 24, 2023 •
edited

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

fix #12593

@pull-request-triage
Copy link

👋 @cicada-ah, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Apr 24, 2023
@github-actions
Copy link

Hello @cicada-ah, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Apr 24, 2023 •
edited

@cicada-ah cicada-ah force-pushed the fix/image_useThrottleFn_trailing branch from 6e76ec1 to d19512b Compare April 24, 2023 18:12
@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Apr 24, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=12596
Please comment the example via this playground if needed.

@cicada-ah
Copy link
Contributor Author

cicada-ah commented Apr 25, 2023 •
edited

Attach the link

@tolking tolking merged commit caae0d1 into element-plus:dev May 1, 2023
9 checks passed
This was referenced May 1, 2023
Closed
Closed
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request May 4, 2023
@cicada-ah @consultation-applio
fix(components): [image] fixed lazyLoad scroll end not loading (eleme…
2556a9b 
…nt-plus#12596)

Co-authored-by: cicada <ruoheng@pinduoduo.com>
This was referenced May 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeftyKoo HeftyKoo HeftyKoo approved these changes

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

Assignees

@cicada-ah cicada-ah

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
4 participants
@cicada-ah @HeftyKoo @tolking @btea