Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [tree] fix always trigger drag #12612

Merged
merged 1 commit into from
May 1, 2023
Merged

fix(components): [tree] fix always trigger drag #12612

merged 1 commit into from
May 1, 2023

Conversation

init-qy
Copy link
Contributor

@init-qy init-qy commented Apr 25, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

close #12089

In fact, oldDropNode !== dropNode will always be true

@pull-request-triage
Copy link

👋 @init-qy, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Apr 25, 2023 •
edited

@github-actions
Copy link

Hello @init-qy, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=12612
Please comment the example via this playground if needed.

@ryuhangyeong ryuhangyeong self-requested a review April 29, 2023 09:51
ryuhangyeong
ryuhangyeong approved these changes Apr 30, 2023
View reviewed changes
Copy link
Member

@ryuhangyeong ryuhangyeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @element-plus/backers

btea
btea approved these changes Apr 30, 2023
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tolking tolking merged commit 9f693f0 into element-plus:dev May 1, 2023
11 checks passed
@Surlyyoung
Copy link

请问什么时候发版本？

consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request May 4, 2023
@init-qy @consultation-applio
fix(components): [tree] fix always trigger drag (element-plus#12612)
038e0fd
@init-qy init-qy deleted the fix-tree-node branch May 10, 2023 09:50
This was referenced May 19, 2023
Closed
Merged
@YunYouJun
Copy link
Member

请问什么时候发版本？

每周五

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@init-qy init-qy

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
6 participants
@init-qy @Surlyyoung @YunYouJun @tolking @btea @ryuhangyeong