Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [input-number] add Judging if the max is greater than the min #12741

Merged
merged 1 commit into from
May 13, 2023
Merged

fix(components): [input-number] add Judging if the max is greater than the min #12741

merged 1 commit into from
May 13, 2023

Conversation

zhengsixsix
Copy link
Contributor

@zhengsixsix zhengsixsix commented May 9, 2023 •
edited

用户在传max的时候可能会小于min 会导致栈溢出 从而打包崩溃 增加判断防止这些问题

closed #12690

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @zhengsixsix, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023 •
edited

@github-actions
Copy link

github-actions bot commented May 9, 2023

Hello @zhengsixsix, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented May 9, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=12741
Please comment the example via this playground if needed.

@zhengsixsix zhengsixsix changed the title fix(components): add Judging if the max is greater than the min fix(components): [input-number] add Judging if the max is greater than the min May 9, 2023
@zhengsixsix
Copy link
Contributor Author

用户在传max的时候可能会小于min 会导致栈溢出 从而打包崩溃 增加判断防止这些问题

闭 #12690

请确保在提交 PR 之前选中这些框，谢谢！

此描述不够准确 正确是 用户在传max的时候可能会小于min 执行build之后 再执行preview 页面是白屏的

@zhengsixsix zhengsixsix requested a review from btea May 11, 2023 13:53
@btea btea closed this May 12, 2023
@btea btea reopened this May 12, 2023
@ryuhangyeong
Copy link
Member

image

test passes but a warning is displayed. can you solve this?

@zhengsixsix
Copy link
Contributor Author

image test passes but a warning is displayed. can you solve this?
image test passes but a warning is displayed. can you solve this?

I seem unable to solve it. The warning message should be caused by the Vue.js framework. The error handler of the Vue.js framework will capture errors and print warning messages. I don't know if the information I found is accurate. In addition, the Slider component also has the same issue.

@btea
Copy link
Collaborator

btea commented May 13, 2023

@ryuhangyeong I think as @zhengsixsix said, this is a deliberately thrown error, and maybe there is no need to solve it.

@ryuhangyeong
Copy link
Member

@btea thanks for the explanation!

@btea btea merged commit 7019407 into element-plus:dev May 13, 2023
10 checks passed
This was referenced May 19, 2023
Closed
Merged
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@zhengsixsix @dannyhebertbell
fix(components): [input-number] add Judging if the max is greater tha…
b3c28f8 
…n the min (element-plus#12741)

fix(components): update Judging if the max is greater than the min

closed element-plus#12741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@zhengsixsix zhengsixsix

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
3 participants
@zhengsixsix @ryuhangyeong @btea