Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [popper] prioritise user's popper-style #12833

Merged
merged 4 commits into from
May 21, 2023
Merged

fix(components): [popper] prioritise user's popper-style #12833

merged 4 commits into from
May 21, 2023

Conversation

Lionad-Morotar
Copy link
Contributor

fix: #12831

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @Lionad-Morotar, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @Lionad-Morotar, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented May 15, 2023 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 15, 2023
@github-actions
Copy link

github-actions bot commented May 15, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=12833
Please comment the example via this playground if needed.

ryuhangyeong
ryuhangyeong reviewed May 16, 2023
View reviewed changes
Copy link
Member

@ryuhangyeong ryuhangyeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lionad-Morotar please check the failing test code

@Lionad-Morotar
Copy link
Contributor Author

@Lionad-Morotar please check the failing test code

testcase fixed

@ryuhangyeong
Copy link
Member

/cc @element-plus/backers

@btea btea merged commit f986b63 into element-plus:dev May 21, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Jun 2, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@Lionad-Morotar @dannyhebertbell
fix(components): [popper] prioritise user's popper-style (element-plu…
022dd0e 
…s#12833)

* fix(components): [popper] prioritise users popper-style

fix: element-plus#12831

* test: fix packages/popper testcase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@Lionad-Morotar Lionad-Morotar

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [popover] 使用el-popover的popper-style属性设置top，left不生效
4 participants
@Lionad-Morotar @ryuhangyeong @tolking @btea