Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [steps] preserve the order of subcomponents #12896

Merged
merged 3 commits into from
May 29, 2023
Merged

fix(components): [steps] preserve the order of subcomponents #12896

merged 3 commits into from
May 29, 2023

Conversation

makedopamine
Copy link
Contributor

@makedopamine makedopamine commented May 20, 2023 •
edited

closes #12811

@pull-request-triage
Copy link

👋 @makedopamine, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @makedopamine, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented May 20, 2023 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 20, 2023
@github-actions
Copy link

github-actions bot commented May 20, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=12896
Please comment the example via this playground if needed.

@tolking
Copy link
Member

tolking commented May 21, 2023

Can you add some tests?

@makedopamine
Copy link
Contributor Author

Can you add some tests?

Sorry for the late reply. I'll add the test cases ASAP.

@tolking tolking merged commit 8fd857a into element-plus:dev May 29, 2023
10 checks passed
@makedopamine makedopamine deleted the fix/step-order branch May 30, 2023 05:08
@element-bot element-bot mentioned this pull request Jun 2, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@makedopamine @dannyhebertbell
fix(components): [steps] preserve the order of subcomponents (element…
5c10642 
…-plus#12896)

* fix(components): [steps] preserve the order of subcomponents

* fix: remove unused type

* add test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

Assignees

@makedopamine makedopamine

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [steps] el-steps: 数据源改变之后，步骤条的顺序出错
3 participants
@makedopamine @tolking @btea