Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [tabs] optimize SSR #15183

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(components): [tabs] optimize SSR #15183

wants to merge 1 commit into from

Conversation

makedopamine
Copy link
Contributor

@makedopamine makedopamine commented Dec 17, 2023 •
edited

@pull-request-triage Pull Request Triage
Copy link

👋 @makedopamine, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2023 •
edited

@github-actions GitHub Actions
Copy link

Hello @makedopamine, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=15183
Please comment the example via this playground if needed.

@makedopamine makedopamine marked this pull request as draft December 17, 2023 15:48
@makedopamine makedopamine changed the title fix(components): [tabs] support SSR fix(components): [tabs] optimize SSR Dec 18, 2023
@makedopamine makedopamine marked this pull request as ready for review December 20, 2023 08:22
tolking
tolking approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@tolking tolking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qcyblm
Copy link

qcyblm commented May 12, 2024

@tolking Looking forward to seeing the update merge. Any idea when it will be pushed?

@makedopamine makedopamine mentioned this pull request May 14, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

Assignees

@makedopamine makedopamine

Labels
breaking change CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [tabs, tab-pane] El-tabs not support SSR.
3 participants
@makedopamine @qcyblm @tolking