Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [radio-button] model-value click style lost and format test file #16692

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

warmthsea
Copy link
Contributor

@warmthsea warmthsea commented Apr 28, 2024

fix: #16689

Before

screenshots

After

screenshots

Copy link

👋 @warmthsea, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

Hello @warmthsea, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

github-actions bot commented Apr 28, 2024

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Apr 28, 2024
Copy link

github-actions bot commented Apr 28, 2024

🧪 Playground Preview: https://element-plus.run/?pr=16692
Please comment the example via this playground if needed.

@toviac
Copy link

toviac commented Apr 28, 2024

这里是不是可以根据is-active类来判断ns.is('active', modelValue === actualValue)
el-radio组件中这个位置是ns.is('checked', modelValue === actualValue),

@warmthsea
Copy link
Contributor Author

这里是不是可以根据is-active类来判断ns.is('active', modelValue === actualValue) el-radio组件中这个位置是ns.is('checked', modelValue === actualValue),

我不确定那种更改方案最好

@makedopamine
Copy link
Contributor

This is along the right lines. I'd like to throw out an idea to fine-tune it.

@include b(radio-button) {
  @include when(active) {
     // checked style here
   }
} 

Then we don't need to change anywhere else. What do you think?

@warmthsea
Copy link
Contributor Author

This is along the right lines. I'd like to throw out an idea to fine-tune it.

@include b(radio-button) {
  @include when(active) {
     // checked style here
   }
} 

Then we don't need to change anywhere else. What do you think?

yes, that's better.

screenshots

@warmthsea warmthsea changed the title fix(components): [radio-button] model-value click style lost fix(components): [radio-button] model-value click style lost and format test file May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [radio-button] radio-group-button的值绑定问题
3 participants