Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(component): select remove-tag event triggered by keydown.delelte #16840

Merged
merged 8 commits into from May 21, 2024
Merged

test(component): select remove-tag event triggered by keydown.delelte #16840

merged 8 commits into from May 21, 2024

Conversation

JiuRanYa
Copy link
Contributor

fix #16831

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage Pull Request Triage
Copy link

👋 @JiuRanYa, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels May 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

@github-actions GitHub Actions
Copy link

Hello @JiuRanYa, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=16840
Please comment the example via this playground if needed.

@btea
Copy link
Collaborator

btea commented May 13, 2024

#16832 has fixed related issues, so this PR should specifically add relevant test cases.

@JiuRanYa
Copy link
Contributor Author

@btea Sure.I have removed that event.

@JiuRanYa JiuRanYa changed the title fix(component): select delete prev tag emit remove tag event test(component): select remove-tag event triggered by keydown.delelte May 14, 2024
@btea
Copy link
Collaborator

btea commented May 14, 2024

The test may go wrong, but don't worry about it, synchronizing the code should be fine after #16832 is merged.

@btea btea mentioned this pull request May 14, 2024
Merged
3 tasks
@btea
Copy link
Collaborator

btea commented May 21, 2024

Thanks !

@btea btea merged commit 4c3c81e into element-plus:dev May 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

Assignees

@JiuRanYa JiuRanYa

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
2 participants
@JiuRanYa @btea