Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [tabs] lssues(#16835) #16847

Closed
wants to merge 1 commit into from

Conversation

Yolo-00
Copy link

@Yolo-00 Yolo-00 commented May 13, 2024

[Component] [tabs] when addable is enabled and tab-position is set to left, the position of the add icon is wrong. #16835

Copy link

👋 @Yolo-00, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels May 13, 2024
Copy link

github-actions bot commented May 13, 2024

Copy link

Hello @Yolo-00, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

🧪 Playground Preview: https://element-plus.run/?pr=16847
Please comment the example via this playground if needed.

Copy link
Contributor

@warmthsea warmthsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀
image

@Yolo-00 Yolo-00 requested a review from warmthsea May 14, 2024 01:29
@Yolo-00
Copy link
Author

Yolo-00 commented May 15, 2024

请问是我提交的 pr 有什么问题吗?
因为是第一次提交 ``pr 有很多地方不太清楚如果有什么问题的话,麻烦提出我这边在做改进

@warmthsea
Copy link
Contributor

请问是我提交的 pr 有什么问题吗? 因为是第一次提交 ``pr 有很多地方不太清楚如果有什么问题的话,麻烦提出我这边在做改进

1、需要把 == 改成 ===
我在你这个 PR 之后提交了一个 新的PR 用来限制 == 的使用
#16860

2、需要更改一下你这条PR的标题(参考其它 PR)

@Yolo-00 Yolo-00 closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants