Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [form] not use status-icon and use slot icon style error #16848

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

warmthsea
Copy link
Contributor

@warmthsea warmthsea commented May 13, 2024

fix: #16846

Before:

use status-icon

screenshots

not use status-icon

screenshots

After:

use status-icon

screenshots

not use status-icon

screenshots

Copy link

👋 @warmthsea, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

github-actions bot commented May 13, 2024

Copy link

Hello @warmthsea, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

github-actions bot commented May 13, 2024

🧪 Playground Preview: https://element-plus.run/?pr=16848
Please comment the example via this playground if needed.

@btea
Copy link
Collaborator

btea commented May 13, 2024

If you change it like this, when setting status-icon to true, the corresponding icon will not be displayed.
link

@warmthsea
Copy link
Contributor Author

If you change it like this, when setting status-icon to true, the corresponding icon will not be displayed.

link

Yes, I'm in a hurry to submit it. It seems that it needs to be modified.

Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants