New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(components): [switch] switch to script-setup syntax #7792
Conversation
🧪 Playground Preview: https://element-plus.run/?pr=7792 |
@chenxch Don't do
in your description because that will close the issue 😢 You just mention it in the comment would be fin.e |
thx, I will pay attention to the description later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments for you to consider. 🏓 back to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks pretty much good to me, left a few comments for you to consider, back to you 🏓
@JeremyWuuuuu I adjusted accordingly and rechecked the logic of the code. In the review of the previous |
Got it. |
cc @jw-foss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @chenxch Could you please rebase your code and I will review this PR.
21eead6
to
9d3317b
Compare
9d3317b
to
f9a9ac8
Compare
cc @sxzz |
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.