Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): [switch] switch to script-setup syntax #7792

Merged
merged 1 commit into from Jun 21, 2022

Conversation

chenxch
Copy link
Member

@chenxch chenxch commented May 19, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@github-actions
Copy link

github-actions bot commented May 19, 2022

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 19, 2022
@github-actions
Copy link

github-actions bot commented May 19, 2022

🧪 Playground Preview: https://element-plus.run/?pr=7792
Please comment the example via this playground if needed.

@chenxch chenxch mentioned this pull request May 19, 2022
80 tasks
@jw-foss
Copy link
Member

jw-foss commented May 20, 2022

@chenxch Don't do

- fix xxx

in your description because that will close the issue 😢

You just mention it in the comment would be fin.e

@chenxch
Copy link
Member Author

chenxch commented May 20, 2022

@chenxch Don't do

- fix xxx

in your description because that will close the issue 😢

You just mention it in the comment would be fin.e

thx, I will pay attention to the description later.

Copy link
Member

@jw-foss jw-foss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments for you to consider. 🏓 back to you

packages/components/switch/__tests__/switch.test.tsx Outdated Show resolved Hide resolved
packages/components/switch/src/switch.vue Outdated Show resolved Hide resolved
packages/components/switch/src/switch.vue Show resolved Hide resolved
packages/components/switch/src/switch.vue Outdated Show resolved Hide resolved
packages/components/switch/src/switch.vue Outdated Show resolved Hide resolved
packages/components/switch/src/switch.vue Outdated Show resolved Hide resolved
@github-actions github-actions bot added CommitMessage::Unqualified Unqualified commit message and removed CommitMessage::Qualified Qualified commit message labels May 20, 2022
Copy link
Member

@jw-foss jw-foss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks pretty much good to me, left a few comments for you to consider, back to you 🏓

packages/components/switch/src/switch.vue Outdated Show resolved Hide resolved
packages/components/switch/src/switch.vue Outdated Show resolved Hide resolved
packages/components/switch/src/switch.vue Outdated Show resolved Hide resolved
@chenxch
Copy link
Member Author

chenxch commented May 24, 2022

@JeremyWuuuuu I adjusted accordingly and rechecked the logic of the code. In the review of the previous watch(()=>props.modelValue,...) section, I thought that the original logic should be maintained, and the change of whether the controllable switch is there, I reopened the previous dialogue.

@jw-foss
Copy link
Member

jw-foss commented May 26, 2022

@JeremyWuuuuu I adjusted accordingly and rechecked the logic of the code. In the review of the previous watch(()=>props.modelValue,...) section, I thought that the original logic should be maintained, and the change of whether the controllable switch is there, I reopened the previous dialogue.

Got it.

@sxzz sxzz removed the CommitMessage::Unqualified Unqualified commit message label May 28, 2022
@chenxch
Copy link
Member Author

chenxch commented May 31, 2022

cc @jw-foss

@github-actions github-actions bot added the CommitMessage::Unqualified Unqualified commit message label May 31, 2022
@sxzz sxzz self-requested a review June 20, 2022 18:38
Copy link
Collaborator

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chenxch Could you please rebase your code and I will review this PR.

@chenxch chenxch force-pushed the refactor/switch_script-setup branch from 21eead6 to 9d3317b Compare June 21, 2022 12:53
@chenxch chenxch force-pushed the refactor/switch_script-setup branch from 9d3317b to f9a9ac8 Compare June 21, 2022 13:12
@github-actions github-actions bot added CommitMessage::Qualified Qualified commit message and removed CommitMessage::Unqualified Unqualified commit message labels Jun 21, 2022
@chenxch
Copy link
Member Author

chenxch commented Jun 21, 2022

cc @sxzz

@sxzz sxzz merged commit ecadb2f into dev Jun 21, 2022
@sxzz sxzz deleted the refactor/switch_script-setup branch June 21, 2022 16:16
@element-bot element-bot mentioned this pull request Jul 1, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants