Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [space] missing empty string size #8039

Merged
merged 5 commits into from Jun 22, 2022

Conversation

HeftyKoo
Copy link
Member

@HeftyKoo HeftyKoo commented Jun 1, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @HeftyKoo, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 1, 2022
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

🧪 Playground Preview: https://element-plus.run/?pr=8039
Please comment the example via this playground if needed.

@jw-foss
Copy link
Member

jw-foss commented Jun 2, 2022

Syntactically I don't think we need this maybe adding fallbacks to falsy value might be a better solution?

@jw-foss jw-foss requested a review from a team June 2, 2022 03:13
@tolking
Copy link
Member

tolking commented Jun 2, 2022

This is indeed a ts syntax error, maybe the components size should not accept '' value.

@HeftyKoo
Copy link
Member Author

HeftyKoo commented Jun 2, 2022

Syntactically I don't think we need this maybe adding fallbacks to falsy value might be a better solution?

It's more like a typo issue, may be exclude the empty string is better.

@sxzz sxzz enabled auto-merge (squash) June 21, 2022 18:58
@sxzz sxzz merged commit 8f0341b into element-plus:dev Jun 22, 2022
@HeftyKoo HeftyKoo deleted the fix/space-type branch June 22, 2022 15:40
@element-bot element-bot mentioned this pull request Jul 1, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants