Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [TreeSelect] checkbox interaction #8102

Merged
merged 9 commits into from Jul 2, 2022
Merged

fix(components): [TreeSelect] checkbox interaction #8102

merged 9 commits into from Jul 2, 2022

Conversation

yujinpan
Copy link
Member

@yujinpan yujinpan commented Jun 5, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Fix:

Docs:

  • update checkbox examples and tips

@pull-request-triage
Copy link

👋 @yujinpan, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Jun 5, 2022 •
edited

@github-actions github-actions bot added the CommitMessage::Unqualified Unqualified commit message label Jun 5, 2022
@github-actions
Copy link

github-actions bot commented Jun 5, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=8102
Please comment the example via this playground if needed.

@github-actions github-actions bot added CommitMessage::Qualified Qualified commit message and removed CommitMessage::Unqualified Unqualified commit message labels Jun 5, 2022
@yujinpan yujinpan requested a review from chenxch June 29, 2022 01:16
@chenxch
Copy link
Member

chenxch commented Jun 29, 2022

Sorry, I'm not very familiar with this component and I need some time to understand.

@yujinpan
Copy link
Member Author

Sorry, I'm not very familiar with this component and I need some time to understand.

Thank you!

@yujinpan yujinpan merged commit 4fe9c2b into element-plus:dev Jul 2, 2022
@element-bot element-bot mentioned this pull request Jul 8, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxch chenxch chenxch approved these changes

Assignees

@yujinpan yujinpan

Labels
CommitMessage::Qualified Qualified commit message Component::TreeSelect Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yujinpan @chenxch