Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [popover] fix dark mode background color #8133

Merged
merged 2 commits into from Jun 25, 2022

Conversation

holazz
Copy link
Member

@holazz holazz commented Jun 6, 2022

fixes #8113

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @holazz, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

Hello @holazz, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

🧪 Playground Preview: https://element-plus.run/?pr=8133
Please comment the example via this playground if needed.

@jw-foss jw-foss requested a review from YunYouJun June 8, 2022 01:37
@jw-foss
Copy link
Member

jw-foss commented Jun 8, 2022

@YunYouJun PTAL

@YunYouJun
Copy link
Member

I think we should modify here.

'bg-color': getCssVar('color-white'),

@holazz
Copy link
Member Author

holazz commented Jun 8, 2022

I think we should modify here.

'bg-color': getCssVar('color-white'),

agree.

@holazz
Copy link
Member Author

holazz commented Jun 8, 2022

background: getCssVar('popover-bg-color');

Or is it possible to remove the background here? because the same style is defined on el-popper.

@holazz
Copy link
Member Author

holazz commented Jun 8, 2022

background: getCssVar('popover-bg-color');

Or is it possible to remove the background here? because the same style is defined on el-popper.

border-radius: getCssVar('popover-border-radius');

border-radius is also.

@YunYouJun
Copy link
Member

We can remove $popover.border-radius and use getCssVar('border-radius', 'base').

But popover-bg-color can be kept because the user may want to customize the popover by modifying the variables.

What is your opinion?

@holazz
Copy link
Member Author

holazz commented Jun 8, 2022

We can remove $popover.border-radius and use getCssVar('border-radius', 'base').

But popover-bg-color can be kept because the user may want to customize the popover by modifying the variables.

What is your opinion?

I missed that point, you are right.

@YunYouJun YunYouJun merged commit 5c0e1b9 into element-plus:dev Jun 25, 2022
@holazz holazz deleted the fix/popover_style branch June 25, 2022 13:37
@element-bot element-bot mentioned this pull request Jul 1, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants