Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(components): [slider] use JSX in Unit test #8225

Merged
merged 2 commits into from Jun 21, 2022
Merged

refactor(components): [slider] use JSX in Unit test #8225

merged 2 commits into from Jun 21, 2022

Conversation

holazz
Copy link
Member

@holazz holazz commented Jun 12, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @holazz, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Jun 12, 2022 •
edited

@github-actions
Copy link

Hello @holazz, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@holazz
Copy link
Member Author

holazz commented Jun 12, 2022

@sxzz Please review.

@github-actions
Copy link

github-actions bot commented Jun 12, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=8225
Please comment the example via this playground if needed.

@holazz
Copy link
Member Author

holazz commented Jun 13, 2022

@sxzz ci fails due to actions/setup-node#516

@sxzz sxzz merged commit 518db1e into element-plus:dev Jun 21, 2022
@holazz holazz deleted the refactor/slider_tests branch June 22, 2022 09:35
@element-bot element-bot mentioned this pull request Jul 1, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees

@holazz holazz

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@holazz @sxzz