Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): [popover] switch to script-setup syntax #8273

Merged
merged 1 commit into from Jun 21, 2022

Conversation

holazz
Copy link
Member

@holazz holazz commented Jun 15, 2022

#6114

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @holazz, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @holazz, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jun 15, 2022

@holazz
Copy link
Member Author

holazz commented Jun 15, 2022

cc @sxzz

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 15, 2022
@github-actions
Copy link

github-actions bot commented Jun 15, 2022

🧪 Playground Preview: https://element-plus.run/?pr=8273
Please comment the example via this playground if needed.

@holazz holazz force-pushed the refactor/popover_script-setup branch from 70d0077 to 57a06f3 Compare June 18, 2022 03:03
@sxzz sxzz merged commit ed174ff into element-plus:dev Jun 21, 2022
@holazz holazz deleted the refactor/popover_script-setup branch June 22, 2022 09:36
@element-bot element-bot mentioned this pull request Jul 1, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants