Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): [dialog] using addUnit in the use-dialog #8304

Merged
merged 1 commit into from Jun 17, 2022
Merged

refactor(components): [dialog] using addUnit in the use-dialog #8304

merged 1 commit into from Jun 17, 2022

Conversation

ryuhangyeong
Copy link
Member

Description

hello. We're looking at the components little by little, looking for bugs or refactoring deprecated APIs and code.

I think you can achieve what you want a little more concisely using the addUnit function.

thank you Element Plus Team!


Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @ryuhangyeong, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Jun 16, 2022

@github-actions
Copy link

Hello @ryuhangyeong, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jun 16, 2022

🧪 Playground Preview: https://element-plus.run/?pr=8304
Please comment the example via this playground if needed.

@ryuhangyeong ryuhangyeong changed the title refactor(components): [dialog] replace with addUnit in use-dialog refactor(components): [dialog] using addUnit in the use-dialog Jun 16, 2022
@sxzz sxzz merged commit 4ac10cf into element-plus:dev Jun 17, 2022
@element-bot element-bot mentioned this pull request Jul 1, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants