Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [message-box] the focus error when used ElMessageBox #8336

Merged
merged 2 commits into from Jun 19, 2022
Merged

fix(components): [message-box] the focus error when used ElMessageBox #8336

merged 2 commits into from Jun 19, 2022

Conversation

LinZhanMing
Copy link
Contributor

@LinZhanMing LinZhanMing commented Jun 17, 2022 •
edited by tolking

fix #8292

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @LinZhanMing, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jun 17, 2022
@github-actions
Copy link

github-actions bot commented Jun 17, 2022 •
edited

@github-actions
Copy link

Hello @LinZhanMing, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@LinZhanMing LinZhanMing changed the title fix: issue #8292 MessageBox error focus fix: issue #8292 Jun 17, 2022
@LinZhanMing LinZhanMing changed the title fix: issue #8292 fix(components): [MessageBox] #8292 Jun 18, 2022
@LinZhanMing LinZhanMing changed the title fix(components): [MessageBox] #8292 fix(components): [message-box] #8292 Jun 18, 2022
@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 19, 2022
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=8336
Please comment the example via this playground if needed.

@tolking tolking changed the title fix(components): [message-box] #8292 fix(components): [message-box] the focus error when used ElMessageBox Jun 19, 2022
@tolking tolking merged commit 9da7564 into element-plus:dev Jun 19, 2022
@tolking
Copy link
Member

tolking commented Jun 19, 2022

LGTM, thanks for your contribution.

@element-bot element-bot mentioned this pull request Jul 1, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

Assignees

@LinZhanMing LinZhanMing

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report] [Component] [message-box] MessageBox close icon default color error when custom components
2 participants
@LinZhanMing @tolking