Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [autocomplete] the popup still appears after select #8350

Merged
merged 1 commit into from Jun 19, 2022

Conversation

tolking
Copy link
Member

@tolking tolking commented Jun 19, 2022

fix #8097, fix #8334, close #8110

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Ignore the focus event of the input when the popup appears.

So, the isClear and nextTick is therefore not required.

@github-actions
Copy link

github-actions bot commented Jun 19, 2022

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 19, 2022
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=8350
Please comment the example via this playground if needed.

@tolking tolking requested a review from a team June 19, 2022 03:25
@chenxch
Copy link
Member

chenxch commented Jun 19, 2022

LGTM.

@chenxch chenxch merged commit bc230e5 into element-plus:dev Jun 19, 2022
LinZhanMing pushed a commit to LinZhanMing/element-plus that referenced this pull request Jun 20, 2022
@element-bot element-bot mentioned this pull request Jul 1, 2022
3 tasks
@zybieku
Copy link

zybieku commented Jul 2, 2022

更新2.2.8, 还是有问题, 虽然选中item之后,没有再触发popup appears , 但我再次点击输入框 ,也不会触发popup appears ,一定要失去焦点才能再触发

@tolking
Copy link
Member Author

tolking commented Jul 2, 2022

@zybieku 值变动也会重新触发弹窗,这是自动补全组件,是根据输入内容提供对应的输入建议。而不是像Select一样选择,所以目前没有处理你说这种情况。

如果你仍然想要这个功能可以提个功能需求进行讨论

@zybieku
Copy link

zybieku commented Jul 2, 2022

@zybieku 值变动也会重新触发弹窗,这是自动补全组件,是根据输入内容提供对应的输入建议。而不是像Select一样选择,所以目前没有处理你说这种情况。

如果你仍然想要这个功能可以提个功能需求进行讨论

那到不用,我手动blur就好! 只是不明白, 这actived的场景是啥,既然是根据输入建议,区别于Select, 那trigger-on-focus默认false是不是会更好

@tolking
Copy link
Member Author

tolking commented Jul 3, 2022

@zybieku 考虑到 A11y 我是不建议手动 blur 的。你反馈的问题确实可以优化,你有意向处理这个吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
4 participants