Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [tabs] name is number 0 become a string #8469

Merged
merged 1 commit into from Jun 29, 2022
Merged

fix(components): [tabs] name is number 0 become a string #8469

merged 1 commit into from Jun 29, 2022

Conversation

chenxch
Copy link
Member

@chenxch chenxch commented Jun 25, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

#8467

@github-actions
Copy link

github-actions bot commented Jun 25, 2022 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 25, 2022
@github-actions
Copy link

github-actions bot commented Jun 25, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=8469
Please comment the example via this playground if needed.

@chenxch
Copy link
Member Author

chenxch commented Jun 25, 2022

@tolking Processed and needs your review again.

@ryuhangyeong
Copy link
Member

@chenxch CI is broken. Please check again!

@chenxch
Copy link
Member Author

chenxch commented Jun 25, 2022

@chenxch CI is broken. Please check again!

I checked now, the local unit test is passed.

@sxzz
Copy link
Collaborator

sxzz commented Jun 25, 2022

Please check TS error.
image

tolking
tolking reviewed Jun 26, 2022
View reviewed changes
packages/tokens/tabs.ts Outdated Show resolved Hide resolved
@chenxch
Copy link
Member Author

chenxch commented Jun 28, 2022

@tolking Do I need to do rebase processing?

@tolking
Copy link
Member

tolking commented Jun 28, 2022

Commit info can be modified by merge PR. If, You need to modify it and you can merge it yourself

@chenxch
Copy link
Member Author

chenxch commented Jun 28, 2022

OK, I've merged the commits via rebase.

@tolking tolking merged commit 08e0204 into dev Jun 29, 2022
@tolking tolking deleted the fix/tabs_name_number branch June 29, 2022 01:11
@element-bot element-bot mentioned this pull request Jul 1, 2022
Merged
3 tasks
@tolking tolking mentioned this pull request Jul 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

Assignees

@chenxch chenxch

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chenxch @ryuhangyeong @sxzz @tolking