Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [radio] Divide attrs into label and input #8476

Merged
merged 3 commits into from Jun 28, 2022
Merged

fix(components): [radio] Divide attrs into label and input #8476

merged 3 commits into from Jun 28, 2022

Conversation

chenxch
Copy link
Member

@chenxch chenxch commented Jun 25, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

fix #8449

@github-actions
Copy link

github-actions bot commented Jun 25, 2022 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 25, 2022
@github-actions
Copy link

github-actions bot commented Jun 25, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=8476
Please comment the example via this playground if needed.

@chenxch
Copy link
Member Author

chenxch commented Jun 28, 2022

cc @tolking

@tolking tolking merged commit 2d8a9e4 into dev Jun 28, 2022
@tolking tolking deleted the fix/radio_id_resubmit branch June 28, 2022 14:57
@element-bot element-bot mentioned this pull request Jul 1, 2022
Merged
3 tasks
chenxch added a commit that referenced this pull request Jul 6, 2022
@chenxch
Revert "fix(components): [radio] Divide attrs into label and input (#…
1e44f35 
…8476)"

This reverts commit 2d8a9e4.
plainheart pushed a commit that referenced this pull request Jul 7, 2022
@chenxch
revert(components): [radio] revert input id (#8677)
468c3a3 
* Revert "fix(components): [radio] fix typo (#8556)"

This reverts commit b922b9e.

* Revert "fix(components): [radio] Divide attrs into label and input (#8476)"

This reverts commit 2d8a9e4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

Assignees

@chenxch chenxch

Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [radio] el-radio id无效问题
2 participants
@chenxch @tolking