Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [radio] fix typo #8556

Merged
merged 1 commit into from Jul 1, 2022
Merged

fix(components): [radio] fix typo #8556

merged 1 commit into from Jul 1, 2022

Conversation

holazz
Copy link
Member

@holazz holazz commented Jun 30, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @holazz, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Jun 30, 2022 •
edited

@github-actions
Copy link

Hello @holazz, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=8556
Please comment the example via this playground if needed.

@btea btea requested a review from chenxch June 30, 2022 13:40
@plainheart plainheart merged commit b922b9e into element-plus:dev Jul 1, 2022
@holazz holazz deleted the fix/radio_typo branch July 1, 2022 08:22
@element-bot element-bot mentioned this pull request Jul 1, 2022
Merged
3 tasks
chenxch added a commit that referenced this pull request Jul 6, 2022
@chenxch
Revert "fix(components): [radio] fix typo (#8556)"
8c2f25e 
This reverts commit b922b9e.
@chenxch chenxch mentioned this pull request Jul 6, 2022
Closed
chenxch added a commit that referenced this pull request Jul 6, 2022
@chenxch
Revert "fix(components): [radio] fix typo (#8556)"
ec34126 
This reverts commit b922b9e.
plainheart pushed a commit that referenced this pull request Jul 7, 2022
@chenxch
revert(components): [radio] revert input id (#8677)
468c3a3 
* Revert "fix(components): [radio] fix typo (#8556)"

This reverts commit b922b9e.

* Revert "fix(components): [radio] Divide attrs into label and input (#8476)"

This reverts commit 2d8a9e4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@plainheart plainheart plainheart approved these changes

@chenxch chenxch Awaiting requested review from chenxch

Assignees

@holazz holazz

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@holazz @btea @plainheart