Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [input-number] Fix value decimals miss prop precision #8587

Merged
merged 5 commits into from Jul 2, 2022

Conversation

so11y
Copy link
Contributor

@so11y so11y commented Jul 1, 2022

input-number components modelValue is decimals and stepStrictly miss prop precision if 0.2 to 0.3 result 0.300004
fix:stepStrictly verifyValue function miss use toPrecision
close #8570

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @so11y, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jul 1, 2022
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Hello @so11y, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

🧪 Playground Preview: https://element-plus.run/?pr=8587
Please comment the example via this playground if needed.

@btea
Copy link
Collaborator

btea commented Jul 2, 2022

Unit tests seem to fail

@ryuhangyeong
Copy link
Member

Sorry. I hadn't thought about the TypeScript type checker error.

@so11y
Copy link
Contributor Author

so11y commented Jul 2, 2022

Unit tests seem to fail

why code typecheck report increase exist error

const elInputNumber = wrapper.findComponent(InputNumber).vm  
 wrapper.findComponent({ name: 'ElInputNumber' }).vm

but code ok

@chenxch chenxch merged commit d20e58e into element-plus:dev Jul 2, 2022
@ryuhangyeong
Copy link
Member

@so11y

Sorry for the confusion!

@so11y
Copy link
Contributor Author

so11y commented Jul 2, 2022

@ryuhangyeong

no sry, smile, the question is solved

@so11y

Sorry for the confusion!

no sry, smile, the question is solved

@element-bot element-bot mentioned this pull request Jul 8, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [input-number] 数字精度问题
4 participants