Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): [tabs] add deprecated to activeName #8590

Merged
merged 1 commit into from Jul 2, 2022

Conversation

tolking
Copy link
Member

@tolking tolking commented Jul 2, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

The activeName attribute seems to be redundant now, and it repeats with the model-value / v-model. I did not find it in the docs, I think we can consider remove the activeName attribute.

@github-actions
Copy link

github-actions bot commented Jul 2, 2022

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jul 2, 2022
@github-actions
Copy link

github-actions bot commented Jul 2, 2022

🧪 Playground Preview: https://element-plus.run/?pr=8590
Please comment the example via this playground if needed.

@btea btea merged commit 59392fa into dev Jul 2, 2022
@btea btea deleted the refactor/tabs-activeName branch July 2, 2022 14:06
@element-bot element-bot mentioned this pull request Jul 8, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants