Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [upload] add uid for file handleStart #9876

Merged
merged 2 commits into from Oct 28, 2022

Conversation

init-qy
Copy link
Contributor

@init-qy init-qy commented Sep 23, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

closed #9755

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @init-qy, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @init-qy, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Sep 23, 2022

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Sep 23, 2022
@github-actions
Copy link

github-actions bot commented Sep 23, 2022

🧪 Playground Preview: https://element-plus.run/?pr=9876
Please comment the example via this playground if needed.

Copy link
Collaborator

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think uid will be added here

@init-qy
Copy link
Contributor Author

init-qy commented Oct 19, 2022

I think uid will be added here

In this case demo

user use submit method which does not run uploadFiles,

function submit() {
uploadFiles.value
.filter(({ status }) => status === 'ready')
.forEach(({ raw }) => raw && uploadRef.value?.upload(raw))
}

and this cause the problem

Perhaps we should change the method submit?

@init-qy init-qy requested a review from sxzz October 19, 2022 10:14
@chenxch
Copy link
Member

chenxch commented Oct 24, 2022

Since pasting does not trigger onStart, the uid can only be added in the modified place, do you have a better solution.

cc @element-plus/backers

@chenxch chenxch merged commit 48f837b into element-plus:dev Oct 28, 2022
@element-bot element-bot mentioned this pull request Nov 6, 2022
3 tasks
@init-qy init-qy deleted the fix/upload branch May 10, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [upload] 【el-upload】No successful callback is triggered after the submit method is called
4 participants