Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for component name change (semantical improvements) #190

Open
Evanion opened this issue Nov 28, 2016 · 1 comment
Open

Proposal for component name change (semantical improvements) #190

Evanion opened this issue Nov 28, 2016 · 1 comment

Comments

@Evanion
Copy link

Evanion commented Nov 28, 2016

I was pleasantly surprised to see that your grid system was not following the same old table inspired structure that most UIKits does.

But I would make a semantical change in your grid system to reinforce this, and avoid developers implementing it in a wrong way.

Rename <Row /> to <Grid />
I would also add the ability to set a default value for the Columns in the wrapping <Grid /> component.
Here is an example of the change:

<Grid xs="1/1" sm="1/2" md="1/3" lg="1/4">
	<Col>
		<DemoBox>Box 1</DemoBox>
	</Col>
	<Col md="2/3">
		<DemoBox>Box 2</DemoBox>
	</Col>
	<Col lg="1/2">
		<DemoBox>Box 3</DemoBox>
	</Col>
	<Col lg="1/2">
		<DemoBox>Box 4</DemoBox>
	</Col>
	<Col>
		<DemoBox>Box 5</DemoBox>
	</Col>
</Grid>
@Evanion Evanion changed the title Proposal for component name changes (semantical improvements) Proposal for component name change (semantical improvements) Nov 28, 2016
@jossmac
Copy link
Member

jossmac commented Sep 9, 2017

Sounds good @Evanion

How do you propose the <Col /> inherit its size; via context or cloneElement?

Would love a PR for this 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants