Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meson: rebuild without requiring ninja clean #1202

Open
danirabbit opened this issue Apr 25, 2022 · 4 comments
Open

Meson: rebuild without requiring ninja clean #1202

danirabbit opened this issue Apr 25, 2022 · 4 comments

Comments

@danirabbit
Copy link
Member

What Happened?

The stylesheet doesn't get properly rebuilt if you build with just ninja and not ninja clean.

Steps to Reproduce

  1. Build with ninja
  2. Make changes and build again with ninja
  3. Test and see that changes weren't built

Expected Behavior

The build system should be set up such that it produces new builds reflecting the latest source code changes when building with ninja and not requiring ninja clean

OS Version

7.x (Early Access)

Software Version

Compiled from git

Log Output

No response

Hardware Info

No response

@eli-schwartz
Copy link

Meson only knows about the primary input file, which just loads other files. In order to do proper incremental updates, you will need depfile support (the same minimal, Make-compatible output: input1 input2 input3 format emitted by GCC's -MD flag); it seems sassc is in deep maintenance mode so it's not clear that such support will ever land upstream.

(No, dart-sass doesn't support this either.)

@eli-schwartz
Copy link

Hmm, turns out there is indeed a PR sort of like this (my original google-fu didn't find it due to it not having the right keywords).

sass/sassc#228

@BAProductions
Copy link

When I build the theme in a VM the changes do take effect

@BAProductions
Copy link

Mabe eOS could add Compiling support to the code app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants