Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'assert (boolean) 를 사용하지 말자' 작성 #35

Open
nallwhy opened this issue Jan 29, 2020 · 2 comments
Open

'assert (boolean) 를 사용하지 말자' 작성 #35

nallwhy opened this issue Jan 29, 2020 · 2 comments
Labels
Projects

Comments

@nallwhy
Copy link
Member

nallwhy commented Jan 29, 2020

No description provided.

@Dalgona Dalgona added this to To do in Publish via automation Jan 29, 2020
@hongsw
Copy link
Contributor

hongsw commented Feb 3, 2020

이건 내용이 궁금하네요 이유도 궁금하구요^^

@nallwhy
Copy link
Member Author

nallwhy commented Feb 3, 2020

이건 내용이 궁금하네요 이유도 궁금하구요^^

제가 얼마전에 boolean 을 반환할 것이라고 기대되는 some_function 에 대해 assert some_function() 과 같이 테스트를 짜놓았었는데, 알고보니 {:error, error} 를 반환하고 있음에도 assert {:error, error} 는 통과가 되기 때문에 문제가 있던 것을 놓치고 있었어서요 ㅋㅋ..

명확하게 assert some_function() == true 와 같이 해야한다고 생각하게 되었습니다...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Publish
  
To do
Development

No branches or pull requests

2 participants