Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship Rhobust Tape Adapter #383

Open
jherdman opened this issue May 20, 2020 · 6 comments
Open

Ship Rhobust Tape Adapter #383

jherdman opened this issue May 20, 2020 · 6 comments

Comments

@jherdman
Copy link

Having code for a Tape adapter is just one step away from actually shipping one. Why not just ship it too?

@teamon
Copy link
Member

teamon commented May 27, 2020

I assume you mean this tape wiki entry.

This is really just a small example - to make it really robust and usable it would require some work, especially configuration and potentially using the test context to choose responses.

@jherdman
Copy link
Author

Is it worth shipping what's in the wiki entry as a means of getting a foot in the door toward a more complete solution?

@teamon
Copy link
Member

teamon commented Jun 15, 2020

I don't think so. Once something is put in master/released version it must stay there and be supported forever (or at least until next major version).

If you simply copy & paste the wiki version into your codebase it is trivial to modify the code when needed. On the other hand, If it is a part of tesla package then you need to either fork tesla itself or copy & paste the adapter code under a different name anyway.

In case anyone is willing to submit a decent version of Tape adapter I'm open to putting it into master.

@stefanchrobot
Copy link

👋 I'm working on an adapter for our use case. I'd be happy to share the code here and open up the discussion about the required features.

@teamon
Copy link
Member

teamon commented Dec 17, 2021

@stefanchrobot 👋

@stefanchrobot
Copy link

@teamon Well, time passed pretty quickly 😅 We haven't done any changes to our implementation so it seems it pretty stable. Let me figure out a way to publish the code. Although I'm thinking more about providing this as an external package, at least initially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Idea
Development

No branches or pull requests

3 participants