Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify configuration #234

Open
teamon opened this issue Aug 10, 2018 · 1 comment · May be fixed by #465
Open

Unify configuration #234

teamon opened this issue Aug 10, 2018 · 1 comment · May be fixed by #465
Labels
idea 💡

Comments

@teamon
Copy link
Member

teamon commented Aug 10, 2018

Currently there is some inconsistency regarding adapter/middleware configuration.
For example, logger format can be configured with config :tesla, Tesla.Middleware.Logger, debug: false but log_level can't.

This all should be unified with clear rules of precedence.
Also relates to #219
@teamon
Copy link
Member Author

teamon commented Aug 10, 2018

Global config override can be useful for cases like changing log level in test:

config :tesla, Tesla.Middleware.Logger, log_level: fn _ -> :info end

(This is currently NOT possible)

@teamon teamon closed this as completed Sep 5, 2019
@teamon teamon reopened this Mar 4, 2020
@thiamsantos thiamsantos linked a pull request May 17, 2021 that will close this issue
Draft
3 tasks
@teamon teamon linked a pull request May 8, 2022 that will close this issue
Unify configuration #465
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
idea 💡
Projects
Roadmap
Status: Idea
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify configuration thiamsantos/tesla
1 participant
@teamon