Fix Lints

[bryanjos]

There are a lot of them!

A good list to look at is here:
https://ebertapp.io/github/elixirscript/elixirscript

The "Quick Fixes" link shows the current list of lint issues

[ghost]

@bryanjos There are only ~750 of them or so :D

I'm happy to start working on some of this for you, I need some real world Elixir experience. Do you have any special instructions (such as using --strict flag) or any specific way you want the PRs to be structured? If not, I'll probably opt to do a file at a time to minimize the scope of changes in each PR.

[bryanjos]

@jodylecompte thanks! Without any flags is fine I think. I would ignore the priv/std_lib/ directory for now. A file at a time is perfect!

[ghost]

@bryanjos I've had a chance to play around and get a little more familiar with the code base enough to go ahead and get started. My only question (so far) is regarding white space around parenthesis and curly braces. A large number of the errors Credo is registering are from such instances, but I wanted to check with you before removing them as they seem to be more by intent than by accident. For example, having a space behind a lodash/throwaway or a space between a curly brace and an atom.

Would you rather these inconsistencies be removed, or Credo configured to ignore them?

[bryanjos]

@jodylecompte I've always had spaces in curly brackets on purpose. That should probably be configured to be ignored.

[workingjubilee]

Hello! Neat project! I was picking through the lint for the JS-end tests and I noticed a lot of them had "unexpected console statement". Seeing as how that lint rule is aimed at browsers, and most of the JavaScript that it's warning on is testing the ElixirScript and outputting legible data for our purposes, would you like that warning disabled in .eslintrc.js? It can be done just for certain files with the files and overrides keys.

[bryanjos]

Hi and yes that would be nice!