-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused functions option #434
Conversation
@@ -14,6 +14,10 @@ defmodule ElixirScript.Translate.Module do | |||
ElixirScript.Translate.Protocol.compile(module, info, pid) | |||
end | |||
|
|||
def compile(_module, %{attributes: [__foreign_info__: %{path: _, name: _, global: _}]}, _) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functions should have a @SPEC type specification.
@@ -90,6 +94,7 @@ defmodule ElixirScript.Compiler do | |||
|> Map.put(:output, Keyword.get(opts, :output)) | |||
|> Map.put(:format, :es) | |||
|> Map.put(:root, Keyword.get(opts, :root, ".")) | |||
|> Map.put(:remove_unused_functions, Keyword.get(opts, :remove_unused_functions, Mix.env == :prod)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long (max is 80, was 103).
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/elixirscript/elixirscript/pulls/434. |
fixes #409