New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(native): Fixed link url in native app #1492
base: main
Are you sure you want to change the base?
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@@ -1,4 +1,6 @@ | |||
<script setup lang="ts"> | |||
import { env } from 'process' | |||
import { metaProperty } from '@babel/types' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these imports needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it was just ts trying to be too clever. I've already removed it.
ae4de62
to
1874cdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see we might have situations like this throughout the app. Maybe a feature we can toggle on in the tauri module that forces the elk.zone
hostname so we don't have to reference tauri here?
@danielroe Because it's just a browser behavior, and Tauri has no control over it. I guess the only thing we could do is to monkey patch |
I understand the need and agree. I'm suggesting that rather than check the environment variable here, we instead have a global setting (maybe in app config) that changes behaviour across everywhere in the app that accesses Edit: I see it's just here and in login that it matters, and we probably shouldn't change that one. I still think a global setting works better. Happy to update within this PR if you don't mind me pushing to it. |
This should fix elk-zone/elk-native/issues/37