Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with cmd k, cmd / #2863

Open
joelanman opened this issue May 4, 2024 · 3 comments
Open

Bug with cmd k, cmd / #2863

joelanman opened this issue May 4, 2024 · 3 comments
Labels
c: bug Something isn't working

Comments

@joelanman
Copy link

If I press cmd k or cmd /, then press esc, I get odd behaviour:

  • I'm jumped to a random point in my feed
  • no other keyboard shortcuts work until I refresh

on Elk main Version canary (0b53dfc@main), Safari MacOS

@joelanman joelanman added c: bug Something isn't working s: pending triage Pending Triage labels May 4, 2024
Copy link

stackblitz bot commented May 4, 2024

Solve in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@lazzzis
Copy link
Contributor

lazzzis commented May 5, 2024

reproducible on firefox as well. At least the "?" does not open the shortcut dialog after pressing "cmd k".

Not reproducible on chrome.

The cause is the notUsingInput is still returns false. And the activeElement is different with document.activeElement.

const notUsingInput = computed(() =>

I thought this should have been fixed by updating vueuse/core #2674, but somehow still broken on Elk. Not sure this is a bug of Elk or vueuse.

Screen.Recording.2024-05-04.at.5.13.01.PM.mov

@lazzzis
Copy link
Contributor

lazzzis commented May 5, 2024

It appears this is because of a behavior difference between Firefox and Chrome. I filed a bug in vueuse vueuse/vueuse#3954

@shuuji3 shuuji3 removed the s: pending triage Pending Triage label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants