Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable Unique #93

Open
Deleplace opened this issue May 4, 2019 · 3 comments
Open

Stable Unique #93

Deleplace opened this issue May 4, 2019 · 3 comments
Labels
question Further information is requested

Comments

@Deleplace
Copy link
Contributor

Unique can be modified at no extra cost to keep the original ordering of the elements. This would seem a sensible default to me.

Shall I write the code and make a PR?

@Deleplace
Copy link
Contributor Author

Deleplace commented May 4, 2019

By the way, thank you again for Pie. I really love the project.

@zhiburt
Copy link
Contributor

zhiburt commented May 4, 2019

(edited)
Hey @Deleplace, nice offer that's worth to do, as I supposed. But it has been documented here
I've been pondering about that, and I've not found any case where it would be important, in fact.
Anyway, I consider it really seems as default behaviour

@elliotchance
Copy link
Owner

I'm impartial either way. I think that performance is more important than retaining the input order. That being said if there is no cost to performance then retaining input order can't be any less useful that randomising the order.

I expect that Unique() would be paired with Sort(), etc if the order matters.

@elliotchance elliotchance added the question Further information is requested label May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants