Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple composable validation #424

Open
TysonMN opened this issue Sep 8, 2021 · 0 comments
Open

Multiple composable validation #424

TysonMN opened this issue Sep 8, 2021 · 0 comments

Comments

@TysonMN
Copy link
Member

TysonMN commented Sep 8, 2021

Now that validation can be added as a composable effect, what should be the behavior when this effect is added more than once to a single binding? The current behavior is to ignore all but the last added validation effect. This is arbitrary and the code to do it is not elegant.

One different solution is to concatenate all the string lists obtained from all the validation effect into a single string list.

However, if we implement the suggestion in #362 to return errors to WPF using the type ObservableCollection<obj> and allow for keyed merges (i.e. merges using IDs), then it is not obvious how multiple validation effects could be merged.

@TysonMN TysonMN changed the title Duplicate composable validation Multiple composable validation Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant