Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] "ScheduleActivity" to "Completed" activity instance. #5355

Open
whoiscxt-zishu opened this issue May 9, 2024 · 1 comment
Open

[FEAT] "ScheduleActivity" to "Completed" activity instance. #5355

whoiscxt-zishu opened this issue May 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@whoiscxt-zishu
Copy link

whoiscxt-zishu commented May 9, 2024

Feature Request

Problem Overview

Is your feature request related to a problem? Please describe.
While run Alteration for "ScheduleActivity", it only support to schedule to "running" activity instance.

I checked source code, it seems that WorkflowInstance.WorkflowState only store ActivityExecutionContext which is "running"?

Proposed Solution

Describe the solution you'd like
Propose to remove status limitation of ActivityExecutionContext while performing "ScheduleActivity"

@whoiscxt-zishu whoiscxt-zishu added the enhancement New feature or request label May 9, 2024
Copy link

glime-ai bot commented May 9, 2024

To address your feature request regarding the ability to schedule a "ScheduleActivity" alteration to an activity instance that has already completed, it's important to understand the current behavior and design of Elsa Workflow's alteration feature.

As per the documentation and the source code, the "ScheduleActivity" alteration is indeed designed to schedule activities that are not yet completed. This is because the typical use case for scheduling activities is to orchestrate the execution flow of activities that are pending or in progress.

However, your request suggests a need to reschedule activities that have already completed, which is not the current behavior of the system. To implement this feature, it would require changes to the core logic of how the workflow engine handles the state of activities and their execution contexts.

The proposed solution would involve modifying the alteration engine to allow scheduling of completed activities. This could potentially be a significant change, depending on how the workflow engine manages the state and history of activity executions.

Before such a feature can be implemented, it would be necessary to consider the following:

  1. Impact on Workflow State: Allowing completed activities to be rescheduled may have implications on the workflow state and history. It's crucial to ensure that such changes do not introduce inconsistencies or unexpected behavior in the workflow execution.

  2. Use Cases: It would be helpful to understand the specific use cases that require rescheduling completed activities. This information can guide the design and implementation of the feature to ensure it meets the needs of users.

  3. Compatibility: Any changes to the workflow engine must maintain backward compatibility with existing workflows and not disrupt current users' processes.

  4. Documentation and Testing: Adequate documentation and thorough testing would be necessary to ensure that users understand the new feature and that it works as intended without introducing bugs.

Given the complexity of this feature request, it would be best to discuss it further with the Elsa Workflow development team, possibly by opening a GitHub issue or contributing to an existing discussion related to this topic. This way, you can collaborate with the maintainers and the community to evaluate the feasibility and plan the implementation of this feature.

This comment was generated by Glime.

@whoiscxt-zishu whoiscxt-zishu changed the title [FEAT] [FEAT] "ScheduleActivity" to "Completed" activity instance. May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant