Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Imported PR] Added missing File Editor functionality #131

Closed
lresende opened this issue Oct 26, 2019 · 4 comments
Closed

[Imported PR] Added missing File Editor functionality #131

lresende opened this issue Oct 26, 2019 · 4 comments
Assignees
@akchinSTC @ajbozarth
Labels
component:python-editor Python editor kind:bug Something isn't working kind:enhancement New feature or request
Milestone
0.2

Comments

@lresende
Copy link
Member

Some functionality of file editor is in the activate function of
fileeditor-extension. This add that missing functionality.

  • Checks for changes and updates the extension config when there
    are changes to the fileeditor-extension settings. This enables
    all msiing functionality based on settings values.

  • Enables Undo/Redo functionality.

  • Enables some editor view options not controlled by configs

Fixes #43
@lresende lresende added kind:bug Something isn't working kind:enhancement New feature or request component:python-editor Python editor labels Oct 26, 2019
@lresende lresende added this to the 0.2 milestone Oct 26, 2019
@lresende
Copy link
Member Author

author: @ajbozarth
Note that this does not depend on my recent changes in jupyterlab for multiple reasons.

  1. My changes are currently only included in the 2.0 alpha releases which we don't want to depend on.

  2. My changes (possibly) introduced a bug into File Editor that should be addressed before updating to.

If/when we update we would only depend on the two menu additions. The large majority of fileeditor-extension's commands are tied to the config/settingRegistry and are handled by the code added in this PR.

While writing this I did find that some functionality is still missing and opened a new Issue to address it in the future ( #127 )

@lresende
Copy link
Member Author

author: @akchinSTC
LGTM

@lresende
Copy link
Member Author

author: @lresende

My changes (possibly) introduced a bug into File Editor that should be addressed before updating to.

Do we have a JupyterLab issue at least describing the possible bug?

@lresende
Copy link
Member Author

author: @ajbozarth
I opened jupyterlab/jupyterlab#7295 on jupyterlab for the bug

harshad16 pushed a commit to harshad16/elyra that referenced this issue Apr 14, 2023
@ajbozarth @lresende
Added missing File Editor functionality (elyra-ai#131)
591d452 
Some functionality of the file editor is in the activate function of
fileeditor-extension. This adds that missing functionality.

- Checks for changes and updates the extension config when there
are changes to the fileeditor-extension settings. This enables
all missing functionality based on settings values.

- Enables Undo/Redo functionality.

- Enables some editor view options not controlled by configs

Fixes elyra-ai#43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akchinSTC akchinSTC

@ajbozarth ajbozarth

Labels
component:python-editor Python editor kind:bug Something isn't working kind:enhancement New feature or request
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
3 participants
@lresende @akchinSTC @ajbozarth