Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernfix.debugReloader should affect datapack reload as well #397

Open
SettingDust opened this issue Apr 21, 2024 · 0 comments
Open

modernfix.debugReloader should affect datapack reload as well #397

SettingDust opened this issue Apr 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@SettingDust
Copy link

SettingDust commented Apr 21, 2024

Bug Description

For now the modernfix.debugReloader only applied in https://github.com/embeddedt/ModernFix/blob/1.16/common/src/main/java/org/embeddedt/modernfix/common/mixin/feature/measure_time/SimpleReloadableResourceManagerMixin.java

But not DataPackContents(ReloadableServerResources in mojmap)
SimpleResourceReload.start(manager, dataPackContents.getContents(), prepareExecutor, applyExecutor, COMPLETED_UNIT, LOGGER.isDebugEnabled())

Modify the boolean in SimpleReloadInstance#create maybe better?

Reproduction Steps

Enable modernfix.debugReloader with JVM flag and join world

Log File

no-op

@embeddedt embeddedt added the enhancement New feature or request label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants