Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning if Embeddium mod file is opened directly #178

Closed
embeddedt opened this issue Jan 21, 2024 · 1 comment
Closed

Add warning if Embeddium mod file is opened directly #178

embeddedt opened this issue Jan 21, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@embeddedt
Copy link
Owner

This mostly involves copying CaffeineMC/sodium-fabric#2250, but the build.gradle change will need to be done differently on 1.18+ as we use NeoGradle instead of Loom.

@embeddedt embeddedt added enhancement New feature or request good first issue Good for newcomers labels Jan 21, 2024
@embeddedt
Copy link
Owner Author

There has never been a single report of anyone trying to open the mod file directly, and the Gradle configuration would have to be done three times: once for ForgeGradle (1.20.1), once for NeoGradle (1.20.6), and once for Loom (both versions). I simply don't have the interest to do that, so this issue will be closed. However, I'll happily accept a PR if someone does wish to add this.

@embeddedt embeddedt closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant