Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow options to dynamically hide/unhide based on the value of other options #285

Open
VOLKOUL opened this issue May 4, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@VOLKOUL
Copy link

VOLKOUL commented May 4, 2024

Bug Description

If you disable Nvidium in the settings, then quit the game and launch it again Nvidium will be reenabled. Also, when disabling Nvidium, Nvidium's options won't automatically gray out (showing that they can't be changed). For them to appear grayed out, you have to exit and reenter the settings. This was not a problem in prior versions. I also had TexTrue's Embeddium Options installed back then.

@embeddedt
Copy link
Owner

The first part of the issue is intended behavior according to Nvidium's code.

@VOLKOUL
Copy link
Author

VOLKOUL commented May 5, 2024

Oh, ok! Apologies :D

@Nolij
Copy link
Contributor

Nolij commented May 6, 2024

Just tested using Embeddium 0.3.14 with and without RSO. It behaves the exact same as the latest 0.3.18 dev build. This can still be considered a bug, but it is not a regression (translation: it didn't work before, and now it's broken; it's always been broken).

@embeddedt
Copy link
Owner

We haven't yet implemented the ability for option screens to dynamically hide and show options based on the value of other options (and Sodium never had it), so this is a feature request. We do intend to implement this at some point but we have to figure out how to do it cleanly first.

@embeddedt embeddedt added the enhancement New feature or request label May 12, 2024
@embeddedt embeddedt changed the title [1.20.1][0.3.17] Reenables Nvidium every game launch. Allow options to dynamically hide/unhide based on the value of other options May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants