Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Embeddium version with loading specific biomes will become laggy #294

Closed
FlappiBakuse opened this issue May 14, 2024 · 10 comments
Closed
Labels
bug This issue has been reproduced and confirmed to be a bug fixed in beta

Comments

@FlappiBakuse
Copy link

Bug Description

I'm using an Intel Arc A770 graphics card with the latest graphics drivers, when I start the game with the latest Embeddium version and create worlds to load specific biomes (eg. jungle, mangrove swamp) the game will become extremely laggy (other biomes will not have this problem), this problem disappeared when I downgraded Embeddium to version 0.3.12.

The following two images will show the difference in performance between different Embeddium versions. (render distance are all set to 32)

2024-05-14_15 47 02

2024-05-14_16 05 43

Reproduction Steps

  1. Install only Embeddium and the latest Forge loader and start the game.
  2. Create single biome world with jungle or mangrove swamp biomes.
  3. Walk around randomly and the game starts to lag.

Log File

debug.log
latest.log

@embeddedt
Copy link
Owner

Hi, thanks for opening an issue. Is performance with this test build similar to 0.3.12?
test_build.zip

@FlappiBakuse
Copy link
Author

Yes, it looks much better now. Thanks for the work!

2024-05-14_22 37 58

@embeddedt
Copy link
Owner

That isn't a fix, it was just me verifying which change caused the problem. 😆 I'm working on a proper fix now.

@embeddedt embeddedt added the bug This issue has been reproduced and confirmed to be a bug label May 14, 2024
embeddedt added a commit that referenced this issue May 14, 2024
This is not obvious in Sodium 0.5.8 because of the original bug,
fixed by me in 09c6306, which
caused the arena to be given excessively large growth amounts in
the first place.

Related: #294
@embeddedt
Copy link
Owner

Okay, does this also fix the issue?

fix.zip

@FlappiBakuse
Copy link
Author

It looks like this version is more unstable compared to the last test version of frametime.

2024-05-14_23 04 01

@embeddedt
Copy link
Owner

How about this?
fix2.zip

@FlappiBakuse
Copy link
Author

It's pretty close to the first test version, but still feels like it has some minor lag.

2024-05-14_23 20 44

@embeddedt
Copy link
Owner

I think it will be close enough. The original test version isn't suitable because it reverts a fix for a crash. The new code strikes a balance between attempting to emulate the old behavior enough to not cause significant lag, while also preventing the excessive memory usage that caused the crash in the first place.

@FlappiBakuse
Copy link
Author

I think there's not a problem, at least it's already in a fully playable state, thanks again for your work.

@embeddedt
Copy link
Owner

The fix has been released in 0.3.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue has been reproduced and confirmed to be a bug fixed in beta
Projects
None yet
Development

No branches or pull requests

2 participants