You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ember Bootstrap currently supports importing Bootstrap's CSS, fonts, and theme into the consuming app. It is controlled by configuration options importBootstrapCSS, importBootstrapFonts, and importBootstrapTheme.
We decided to drop this functionality when migrating to a v2 addon (#1980). To prepare that migration and give users some time to refactor, we should deprecate it as soon as possible.
When Bootstrap's CSS, fonts, or theme is imported, Ember Bootstrap should log a deprecation message at build-time. The logic can be added at the respective places of index.html. E.g. for importing Bootstrap's CSS it can go here:
The deprecation message should educate the developer about the recommended path forward. It should at least include Ember's recommended way today. It may additionally mention best practices for Embroider apps. Additionally it should include required configuration changes to Ember Bootstrap. For importing Bootstrap's CSS a deprecation message may be like the following:
Importing Bootstrap CSS through Ember Bootstrap is deprecated. Application should import Bootstrap's CSS explicitly. Please find information how to do so in the Ember guides: https://guides.emberjs.com/release/addons-and-dependencies/#toc_css Additionally set importBootstrapCSS configuration of Ember Bootstrap in your app's ember-cli-build.js to false. Please find more information about Ember Bootstrap's configuration here: https://www.ember-bootstrap.com/getting-started/setup
The text was updated successfully, but these errors were encountered:
Ember Bootstrap currently supports importing Bootstrap's CSS, fonts, and theme into the consuming app. It is controlled by configuration options
importBootstrapCSS
,importBootstrapFonts
, andimportBootstrapTheme
.We decided to drop this functionality when migrating to a v2 addon (#1980). To prepare that migration and give users some time to refactor, we should deprecate it as soon as possible.
When Bootstrap's CSS, fonts, or theme is imported, Ember Bootstrap should log a deprecation message at build-time. The logic can be added at the respective places of
index.html
. E.g. for importing Bootstrap's CSS it can go here:ember-bootstrap/index.js
Lines 92 to 98 in c963f59
The deprecation message should educate the developer about the recommended path forward. It should at least include Ember's recommended way today. It may additionally mention best practices for Embroider apps. Additionally it should include required configuration changes to Ember Bootstrap. For importing Bootstrap's CSS a deprecation message may be like the following:
The text was updated successfully, but these errors were encountered: