Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-cli 5 makes the quick start guide error #10295

Closed
jacobnlsn opened this issue Jun 13, 2023 · 3 comments
Closed

ember-cli 5 makes the quick start guide error #10295

jacobnlsn opened this issue Jun 13, 2023 · 3 comments

Comments

@jacobnlsn
Copy link

I think the issue is in ember-cli-app-version but posting an issue here for visibility

ember-cli/ember-cli-app-version#410

Full disclosure, looked very little into this. I am new to ember and just having issues going through the quick start guide, so spent some time trying to figure out why.

With ember-cli 5 getting released as latest the quick start guide is failing on ember new ember-quickstart --lang en

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: ember-quickstart@0.0.0
npm ERR! Found: ember-source@5.0.0
npm ERR! node_modules/ember-source
npm ERR! dev ember-source@"~5.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer ember-source@"^3.28.0 || ^4.0.0" from ember-cli-app-version@6.0.0
npm ERR! node_modules/ember-cli-app-version
npm ERR! dev ember-cli-app-version@"^6.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.


Output from ember version --verbose && npm --version && yarn --version:

ember version --verbose && npm --version && yarn --version
ember-cli: 5.0.0
node: 18.16.0
acorn: 8.8.2
ada: 1.0.4
ares: 1.19.0
brotli: 1.0.9
cldr: 42.0
icu: 72.1
llhttp: 6.0.10
modules: 108
napi: 8
nghttp2: 1.52.0
nghttp3: 0.7.0
ngtcp2: 0.8.1
openssl: 3.0.8+quic
simdutf: 3.2.2
tz: 2022g
undici: 5.21.0
unicode: 15.0
uv: 1.44.2
uvwasi: 0.0.15
v8: 10.2.154.26-node.26
zlib: 1.2.13
os: darwin arm64
9.5.1
zsh: command not found: yarn
@simonihmig
Copy link
Contributor

Can confirm. The app blueprint was updated to ember-source@5.0.0, but ember-cli-app-version is causing a peer dependency conflict.

The PR of yours looks good, we should get that package updated asap!

@kategengler
Copy link
Member

kategengler commented Jun 15, 2023

We merged that PR and are waiting for ember-cli/ember-cli-app-version#411 so that we can release a patch of ember-cli-app-version.

I am working on releasing a patch of ember-resolver after merging ember-cli/ember-resolver#916

Also courtesy of @NullVoxPopuli we have a PR for ember-cli-dependency-checker quaertym/ember-cli-dependency-checker#144

This is likely also failing ember-cli's CI as well as the tutorial, but being hidden by ember-template-lint/ember-template-lint#2912 which is causing both to fail as well.

  • ember-resolver v10.1.1
  • ember-cli-dependency-checker v3.3.2
  • ember-cli-app-version v6.0.1

@kategengler
Copy link
Member

I have confirmed the quickstart works now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants