-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated babel-eslint with new @babel/eslint-parser #9307
Comments
I would assume biggest show-stopper here is
because Ember CLI projects do not have dedicated Babel configuration file and may use ember-cli-babel@6. |
I started an implementation in #9532:
|
Perhaps not explicitly, but the default blueprint adds it to new projects. It shouldn't be a surprise to users, either, as the Ember CLI intro explicitly states
If one runs So moving it into package.json as a devDep or peerDep will just now be explicitly stating the dependency exists, rather than it being a transitive dependency. |
@tehhowch great point! In fact, I just noticed that a bunch of other dependencies in a fresh Ember app already have an unmet peer dependency on @babel/core, so I think we can ignore this given that it's most certainly a transitive dependency (and I think ember-cli-babel is intended to be a wrapper around / manage the version of @babel/core anyway). CC: @rwjblue
I have moved my PR #9532 into ready-for-review. |
Relates to emberjs/ember-cli-babel#366 |
Another PR #9669 |
Need to ignore eslint 8 until Ember community fix their issue ember-cli/ember-cli#9307
Need to ignore eslint 8 until Ember community fix their issue ember-cli/ember-cli#9307
Need to ignore eslint 8 until Ember community fix their issue ember-cli/ember-cli#9307
Need to ignore eslint 8 until Ember community fix their issue ember-cli/ember-cli#9307
Need to ignore eslint 8 until Ember community fix their issue ember-cli/ember-cli#9307
Upgrading it seems to break stuff with babel-parser. See: * ember-cli/ember-cli#9307 * ember-cli/ember-cli#9669
Using `ecmaVersion: 'latest'` (introduced in #6) seems to not work at all, due to `babel-eslint` being outdated und unmaintained. This replaces it with is successor `@babel/eslint-parser`. There has been some discussion about doing the same in the main blueprint (see ember-cli/ember-cli#9307 and emberjs/rfcs#817), but in our case the switch should be easy, for example as we already have a `babel.config.js`.
This is mostly a tracking issue as I am not in a place to open a PR for this atm, but,
here in the app blueprint: https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/package.json#L29
we're still using babel-eslint,
but, per, https://github.com/babel/babel-eslint, the eslint parser for babel has moved into their monorepo as https://github.com/babel/babel/tree/master/eslint/babel-eslint-parser
The text was updated successfully, but these errors were encountered: