From e593488e8a659144456f17c1f94d5b4e05606c27 Mon Sep 17 00:00:00 2001 From: Larry Yu Date: Wed, 8 Feb 2023 09:47:27 -0800 Subject: [PATCH] Added a test case to show the regression --- .github/workflows/ci.yml | 2 ++ ...mmy-ember-try-config-fs-extra-scenarios.js | 24 +++++++++++++++++++ 2 files changed, 26 insertions(+) create mode 100644 test/fixtures/dummy-ember-try-config-fs-extra-scenarios.js diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cb7d91da..21485dbc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -115,6 +115,8 @@ jobs: # Environment variables from config - ./node_modules/.bin/ember try:each --config-path='../test/fixtures/dummy-ember-try-config-different-env-vars.js' + # fs-extra versions 7.x and above caused a regresion + - ./node_modules/.bin/ember try:each --config-path='../test/fixtures/dummy-ember-try-config-fs-extra-scenarios.js' steps: - uses: actions/checkout@v1 diff --git a/test/fixtures/dummy-ember-try-config-fs-extra-scenarios.js b/test/fixtures/dummy-ember-try-config-fs-extra-scenarios.js new file mode 100644 index 00000000..071a78f1 --- /dev/null +++ b/test/fixtures/dummy-ember-try-config-fs-extra-scenarios.js @@ -0,0 +1,24 @@ +module.exports = { + scenarios: [ + { + name: 'Ember try should succeed when using fs-extra version 6.x', + npm: { + devDependencies: { + 'watchpack-chokidar2': '2.0.1', + 'ember-try-test-suite-helper': '1.0.0', + 'fs-extra': '6.0.1', + }, + }, + }, + { + name: 'Ember try should fail when using fs-extra version 9.x', + npm: { + devDependencies: { + 'watchpack-chokidar2': '2.0.1', + 'ember-try-test-suite-helper': '1.0.0', + 'fs-extra': '9.0.1', + }, + }, + }, + ], +};